Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added two additional exceptions to emmocheck #577

Merged
merged 4 commits into from
Apr 24, 2023
Merged

Added two additional exceptions to emmocheck #577

merged 4 commits into from
Apr 24, 2023

Conversation

jesper-friis
Copy link
Collaborator

Description:

Added the following two exceptions to emmocheck

  • foaf.logo comes from foaf and does not have a prefLabel
  • Accept 3DPrinting in the DOAM ontology as a valid prefLabel, even though it does not start with a letter

Type of change:

  • Bug fix.
  • New feature.
  • Documentation update.

Checklist:

This checklist can be used as a help for the reviewer.

  • Is the code easy to read and understand?
  • Are comments for humans to read, not computers to disregard?
  • Does a new feature has an accompanying new test (in the CI or unit testing schemes)?
  • Has the documentation been updated as necessary?
  • Does this close the issue?
  • Is the change limited to the issue?
  • Are errors handled for all outcomes?
  • Does the new feature provide new restrictions on dependencies, and if so is this documented?

Comments:

@codecov
Copy link

codecov bot commented Apr 9, 2023 •
edited
Loading

Codecov Report

Merging #577 (d30fdcf) into master (b8e2c63) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #577      +/-   ##
==========================================
+ Coverage   67.25%   67.28%   +0.03%     
==========================================
  Files          16       16              
  Lines        3127     3127              
==========================================
+ Hits         2103     2104       +1     
+ Misses       1024     1023       -1
Impacted Files Coverage Δ
emmopy/emmocheck.py 53.20% <ø> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

francescalb
francescalb requested changes Apr 11, 2023
View reviewed changes
Copy link
Collaborator

@francescalb francescalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think the correct way to go about exceptions to emmocheck for ontologies except emmo itself is to add disregarded labels in emmocheck at top level. Then one should be able to add a list of labels to disregard in emmocheck.

@jesper-friis
Copy link
Collaborator Author

I do not think the correct way to go about exceptions to emmocheck for ontologies except emmo itself is to add disregarded labels in emmocheck at top level. Then one should be able to add a list of labels to disregard in emmocheck.

I fully agree. But these concepts are in EMMO.

@jesper-friis
Copy link
Collaborator Author

Correction. 3DPrinting is not in EMMO any more - so I have removed the exception for that.

@francescalb francescalb merged commit c1137b7 into master Apr 24, 2023
@francescalb francescalb deleted the emmocheck-fixes branch April 24, 2023 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francescalb francescalb francescalb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jesper-friis @francescalb